fix: ensure UTF-8 encoding when reading text files in ingestion helper #2144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that text files are read using UTF-8 encoding in the
_load_file_to_documents
method of the ingestion helper. Previously, the encoding was not explicitly specified, which could lead to issues when handling files with non-UTF-8 encodings.Motivation:
Relevant Context:
Type of Change
How Has This Been Tested?
Code Inspection:
read_text
method.Unit Testing:
Manual Testing:
Test Configuration:
Checklist
make check; make test
to ensuremypy
and tests pass.This structure clearly outlines the change, why it was made, and how it was tested. Let me know if you need further adjustments!