Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fixed typo #410

Merged
merged 2 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ jobs:
- '.github/workflows/example.yml'
- 'docker/**'
- 'tests/**'
- 'action.yml'

# Change detection in action golang code
changes:
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ runs:
run: |
if [ ${{ runner.arch }} = "X64" ]; then
echo "arch=x86_64" >> "${GITHUB_OUTPUT}"
if [ ${{ runner.arch }} = "amd64" ]; then
elif [ ${{ runner.arch }} = "amd64" ]; then
echo "arch=x86_64" >> "${GITHUB_OUTPUT}"
elif [ ${{ runner.arch }} = "X86" ]; then
echo "arch=i386" >> "${GITHUB_OUTPUT}"
Expand Down
2 changes: 2 additions & 0 deletions action/recipes/linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ func (opts LinuxOpts) buildFirmware(ctx context.Context, client *dagger.Client,
err = errUnknownArchCrossCompile
slog.Error(
"Selected unknown cross compilation target architecture",
slog.String("system_architecture", runtime.GOARCH),
slog.String("target_architecture", opts.Arch),
slog.Any("error", err),
)
return nil, err
Expand Down
Loading