Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): fixed typo #410

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(examples): fixed typo #410

merged 2 commits into from
Nov 14, 2024

Conversation

AtomicFS
Copy link
Collaborator

No description provided.

@AtomicFS AtomicFS requested a review from MDr164 as a code owner November 14, 2024 17:37
@AtomicFS AtomicFS added the high_priority Very important label Nov 14, 2024
@github-actions github-actions bot added bugfix Bugfix / fix github_actions Pull requests that update GitHub Actions code labels Nov 14, 2024
@github-actions github-actions bot enabled auto-merge November 14, 2024 17:37
MDr164
MDr164 previously approved these changes Nov 14, 2024
View reviewed changes
@github-actions github-actions bot added this pull request to the merge queue Nov 14, 2024
@AtomicFS AtomicFS removed this pull request from the merge queue due to a manual request Nov 14, 2024
@github-actions github-actions bot enabled auto-merge November 14, 2024 18:46
@AtomicFS
Copy link
Collaborator Author

@MDr164 Works now without changing a thing ... only added a debug code ... don't know what is going on, probably some GitHub nonsense.

@AtomicFS AtomicFS requested a review from MDr164 November 14, 2024 19:00
MDr164
MDr164 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub being weird then

@github-actions github-actions bot added this pull request to the merge queue Nov 14, 2024
@AtomicFS AtomicFS removed this pull request from the merge queue due to a manual request Nov 14, 2024
@AtomicFS AtomicFS added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 22afde5 Nov 14, 2024
67 checks passed
@AtomicFS AtomicFS deleted the fix/examples-attempt3665555 branch November 14, 2024 19:29
@AtomicFS
Copy link
Collaborator Author

Oh, I know now why it behaves the way it does. In examples it is not compiling the firmware-action binary, it is fetching it from releases on GitHub. But we had some breaking changes since.

Problem is that the example CI does not detect that firmware-action needs to be compiled in this instance. It detects if compilation is needed based on diff of action/ directory compared to main and not compared to latest release.

@AtomicFS AtomicFS mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
bugfix Bugfix / fix github_actions Pull requests that update GitHub Actions code high_priority Very important module/linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164