Skip to content

Commit

Permalink
Use compile scope to transitively inherit acs-aem-commons-bundle
Browse files Browse the repository at this point in the history
This eases introducing Cloud-only API as the consumer should only depend
on "acs-aem-commons-bundle-cloud" instead of "acs-aem-commons-bundle"
(when running in AEMaaCS)
  • Loading branch information
kwin committed Apr 9, 2024
1 parent 2bc2400 commit 08e55c4
Showing 1 changed file with 22 additions and 1 deletion.
23 changes: 22 additions & 1 deletion bundle-cloud/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,26 @@ Fragment-Host: com.adobe.acs.acs-aem-commons-bundle
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>enforce-banned-dependencies</id>
<configuration>
<rules>
<bannedDependencies>
<!-- here we need to explicitly list the set of dependencies which
are allowed with scope=compile -->
<includes>
<include>com.adobe.acs:acs-aem-commons-bundle</include>
</includes>
</bannedDependencies>
</rules>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand All @@ -74,7 +94,8 @@ Fragment-Host: com.adobe.acs.acs-aem-commons-bundle
<groupId>com.adobe.acs</groupId>
<artifactId>acs-aem-commons-bundle</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
<!-- this dependency should be transitively inherited -->
<scope>compile</scope>
</dependency>
<!-- Start Test dependencies -->
<dependency>
Expand Down

0 comments on commit 08e55c4

Please sign in to comment.