Improve purse types #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuqiPan
approved these changes
Mar 8, 2024
| @@ -14,9 +17,13 @@ export type PursesJSONState<T extends AssetKind> = { | |||
| /** The petname for this purse */ | |||
| pursePetname: string; | |||
| /** The brand's displayInfo */ | |||
| displayInfo: unknown; | |||
| // XXX Copied from @agoric/ertp/src/types-ambient.js | |||
There was a problem hiding this comment.
question
Just curious, what does XXX stand for here?
There was a problem hiding this comment.
To me it just signals a code smell that isn't really actionable enough for a TODO. Ideally the types would be exported from agoric-sdk as a module instead of being ambient. I'm not sure if there's an issue to track this exactly (my search).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.