Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use uv instead of pip #7

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Switch to use uv instead of pip #7

merged 7 commits into from
Jan 14, 2025

Conversation

rpmcginty
Copy link
Collaborator

@rpmcginty rpmcginty commented Jan 8, 2025

  • add ruff dependency
  • adding uv support
  • switch to use ruff, drop isort/black

What's in this change?

https://alleninstitute.atlassian.net/browse/DT-7088

  • Switching from pip -> uv for dependency and environment management.
    • in github action, adding matrix option for testing against highest and lowest resolution of possible dependency versions based on explicit dependency constraints.
  • switching from black/isort -> ruff (ruff supports current uses of old linters)

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9ebe0a0) to head (62d3095).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           75        76    +1     
  Branches         5         5           
=========================================
+ Hits            75        76    +1     
Files with missing lines Coverage Δ
src/aibs_informatics_test_resources/base.py 100.00% <100.00%> (ø)

@rpmcginty rpmcginty marked this pull request as ready for review January 8, 2025 05:45
@rpmcginty rpmcginty requested review from sheriferson and njmei January 8, 2025 19:06
Makefile Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link

@sheriferson sheriferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the review on Monday

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@rpmcginty rpmcginty requested a review from njmei January 13, 2025 23:04
@rpmcginty rpmcginty merged commit 5d72d72 into main Jan 14, 2025
8 checks passed
@rpmcginty rpmcginty deleted the feature/switch-to-uv branch January 14, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants