Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): demo examples #111

Merged

Conversation

ValentinNelu
Copy link
Contributor

Two examples for the accordion demo taken from ng-bootstrap

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #111 (9f1fb5c) into main (e3886cb) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          53       53           
  Lines        1386     1386           
  Branches      218      218           
=======================================
  Hits         1224     1224           
  Misses        125      125           
  Partials       37       37           
Flag Coverage Δ
e2e-1 59.13% <100.00%> (ø)
e2e-2 37.08% <100.00%> (ø)
e2e-4 61.65% <ø> (ø)
e2e-5 47.47% <ø> (ø)
e2e-7 55.12% <ø> (-4.08%) ⬇️
e2e-8 51.98% <ø> (+1.63%) ⬆️
unit 91.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...gular/lib/src/lib/accordion/accordion.component.ts 4.08% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -0,0 +1,3 @@
.custom-header::after {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put the common css in the common folder.

class="accordion-collapse {{ state!.itemCollapseClass }}"
>
<div class="accordion-body {{ state!.itemBodyClass }}">
Anim pariatur cliche reprehenderit, enim eiusmod high life accusamus terry richardson ad squid. 3 wolf moon officia aute, non cupidatat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content in the panels can be added as a .txt file in the common folder, allowing to have shorter / cleaner code examples.

@ValentinNelu ValentinNelu force-pushed the feat/accordion-examples branch 4 times, most recently from 72a0318 to a70adc0 Compare September 13, 2023 13:32
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@quentinderoubaix quentinderoubaix merged commit b71fa6d into AmadeusITGroup:main Sep 13, 2023
13 checks passed
@ValentinNelu ValentinNelu deleted the feat/accordion-examples branch June 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants