Use stopped() instead of quit flag to exit exec loop #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Oct 1, 2024
greg7mdp
reviewed
Oct 1, 2024
| try { | ||
| io_serv.poll(); // queue up any ready; allowing high priority item to get into the queue | ||
| if (io_serv.stopped()) |
There was a problem hiding this comment.
I wonder if we should also change the is_quitting() function to return io_serv.stopped(), and remove the is_quitting bool?
There was a problem hiding this comment.
It uses a mutex instead of an atomic, but maybe. I don't have a strong opinion either way.
|
Included in #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By checking
is_quitting()before callingpoll()there is the possibility that something was posted but not drained to the priority queue. Instead use theio_contextstopped()to break out of the loop after callingpoll().