Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stopped() instead of quit flag to exit exec loop #35

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/appbase/application_base.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ class application_base {
bool more = true;

while (more || io_serv.run_one()) {
if (is_quiting())
break;
try {
io_serv.poll(); // queue up any ready; allowing high priority item to get into the queue
if (io_serv.stopped())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should also change the is_quitting() function to return io_serv.stopped(), and remove the is_quitting bool?

Copy link
Member Author

@heifner heifner Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses a mutex instead of an atomic, but maybe. I don't have a strong opinion either way.

break;
// execute the highest priority item
more = exec.execute_highest();
} catch (...) {
Expand Down
Loading