refactor(cardinal): register query with generics #434

Sign in to view logs

Triggered via pull request November 9, 2023 06:53

smsunarto

opened #413

11-08-refactor_register_query

Status Failure

Total duration 3m 50s

Artifacts –

lint.yml

on: pull_request

Annotations

10 errors

golangci-lint: internal/e2e/tester/cardinal/query/location.go#L19

undefined: cardinal.NewQueryTypeWithEVMSupport (typecheck)

golangci-lint: internal/e2e/tester/cardinal/main.go#L10

could not import github.com/argus-labs/world-engine/example/tester/query (-: # github.com/argus-labs/world-engine/example/tester/query

golangci-lint: internal/e2e/tester/cardinal/query/location.go#L19

undefined: cardinal.NewQueryTypeWithEVMSupport) (typecheck)

golangci-lint: internal/e2e/tester/cardinal/main.go#L29

too many arguments in call to cardinal.NewWorld

golangci-lint: internal/e2e/tester/cardinal/main.go#L44

undefined: cardinal.RegisterQueries (typecheck)

golangci-lint: cardinal/ecs/query.go#L225

errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)

golangci-lint: cardinal/ecs/world.go#L219

indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)

golangci-lint: cardinal/config.go#L8

var-naming: struct field CardinalWorldId should be CardinalWorldID (revive)

golangci-lint: cardinal/server/query.go#L38

error is not nil (line 36) but it returns nil (nilerr)

golangci-lint

Process completed with exit code 2.