-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cardinal): move context into cardinal #757
Conversation
…world-1110-move-message-and-query-into-cardinal
…world-1110-move-message-and-query-into-cardinal # Conflicts: # cardinal/world.go
…world-1110-move-message-and-query-into-cardinal
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…textmove # Conflicts: # cardinal/cardinal.go # cardinal/cardinal_test.go # cardinal/engine_test.go # cardinal/example_messagetype_test.go # cardinal/message_manager.go # cardinal/plugin_persona.go # cardinal/query.go # cardinal/query_manager.go # cardinal/server/receipts_test.go # cardinal/testutils/testutils.go # cardinal/world.go # cardinal/world_test.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 59.89% 59.88% -0.02%
==========================================
Files 141 140 -1
Lines 7214 7231 +17
==========================================
+ Hits 4321 4330 +9
- Misses 2452 2457 +5
- Partials 441 444 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, looks nice
fa57218
to
4de72df
Compare
All commits need to be signed with a GPG key which did not occur here in this PR. Rather then modify the commits and potentially mangle things or potentially mess with the conversations that occured in this PR, I am creating a new PR where all the commits are squashed into a single commit that is signed. |
@pyrofolium can we close this? |
Yea |
closes WORLD-1112
Very large PR.
For testing just make sure original tests work as no new features are created. This is just reorganization.