Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cardinal): move context into cardinal #757

Closed
wants to merge 81 commits into from
Closed

Conversation

pyrofolium
Copy link
Contributor

@pyrofolium pyrofolium commented May 7, 2024

closes WORLD-1112

Very large PR.

  • context moved into cardinal package
  • internal methods on cardinal package privatized
  • search moved into cardinal package (filters remain in the search package)
  • context dependency removed from server
  • GetTransactionReceiptsForTick created to replace privatized method on ctx (for tests only)
  • GetComponentByNameFromContext created to replace privatized method on ctx (for tests only)
  • GetStoreManagerFromContext created to replace privatized method on ctx (for tests only)
  • Query Interface moved to cardinal

For testing just make sure original tests work as no new features are created. This is just reorganization.

Copy link

graphite-app bot commented May 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

coderabbitai bot commented May 7, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pyrofolium pyrofolium changed the title move message and query into cardinal. Move context into cardinal. DRAFT May 7, 2024
…textmove

# Conflicts:
#	cardinal/cardinal.go
#	cardinal/cardinal_test.go
#	cardinal/engine_test.go
#	cardinal/example_messagetype_test.go
#	cardinal/message_manager.go
#	cardinal/plugin_persona.go
#	cardinal/query.go
#	cardinal/query_manager.go
#	cardinal/server/receipts_test.go
#	cardinal/testutils/testutils.go
#	cardinal/world.go
#	cardinal/world_test.go
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 59.88%. Comparing base (8ad754d) to head (fa57218).

Current head fa57218 differs from pull request most recent head 4de72df

Please upload reports for the commit 4de72df to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   59.89%   59.88%   -0.02%     
==========================================
  Files         141      140       -1     
  Lines        7214     7231      +17     
==========================================
+ Hits         4321     4330       +9     
- Misses       2452     2457       +5     
- Partials      441      444       +3     
Files Coverage Δ
cardinal/message.go 83.46% <100.00%> (ø)
cardinal/persona_signer.go 87.50% <100.00%> (ø)
cardinal/plugin_persona.go 72.72% <100.00%> (ø)
cardinal/query.go 67.14% <100.00%> (ø)
cardinal/router/router.go 30.90% <100.00%> (ø)
cardinal/server/docs/docs.go 100.00% <ø> (ø)
cardinal/server/handler/cql.go 77.77% <100.00%> (+10.21%) ⬆️
cardinal/server/handler/receipts.go 77.14% <100.00%> (ø)
cardinal/server/handler/world.go 100.00% <100.00%> (ø)
cardinal/server/server.go 86.20% <100.00%> (-1.10%) ⬇️
... and 15 more

@pyrofolium pyrofolium requested a review from smsunarto May 15, 2024 20:37
cardinal/gamestate/doc.go Outdated Show resolved Hide resolved
cardinal/gamestate/manager.go Outdated Show resolved Hide resolved
cardinal/testutils/world.go Outdated Show resolved Hide resolved
@pyrofolium pyrofolium requested a review from smsunarto May 17, 2024 18:32
Copy link
Member

@smsunarto smsunarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks nice

@pyrofolium
Copy link
Contributor Author

All commits need to be signed with a GPG key which did not occur here in this PR. Rather then modify the commits and potentially mangle things or potentially mess with the conversations that occured in this PR, I am creating a new PR where all the commits are squashed into a single commit that is signed.

@pyrofolium pyrofolium marked this pull request as draft May 21, 2024 00:48
@smsunarto
Copy link
Member

@pyrofolium can we close this?

Copy link
Contributor Author

Yea

@smsunarto smsunarto closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants