-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not set user commands as rc.__currsys__ #377
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev_master #377 +/- ##
==============================================
- Coverage 74.23% 71.80% -2.44%
==============================================
Files 56 56
Lines 7864 7867 +3
==============================================
- Hits 5838 5649 -189
- Misses 2026 2218 +192 ☔ View full report in Codecov by Sentry. |
I did run all the notebooks in both ScopeSim and the IRDB, and all tests should pass too (as they pass locally), so removing the draft status. |
So this and AstarVienna/irdb#157 kinda go together. So if we merge this, then the current IRDB packages will not work with the dev_master of ScopeSim. But I think it is possible "fix" AstarVienna/irdb#157 so it works with both the current version of ScopeSim and the one after this is merged. Then we can create new IRDB packages that work with both versions, and then we can merge this. |
New packages are here 👍 |
Superset of #376