-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more UserCommands as rc.currsys #157
Conversation
All tests now pass using ScopeSim branch of AstarVienna/ScopeSim#377 . Have not yet tested all the notebooks. |
Did run all the notebooks locally |
All notebooks and tests pass with both ScopeSim dev_master and AstarVienna/ScopeSim#377 , so I suggest we
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Store IFU-example.ipynb
with or without output? Otherwise, LGTM.
I can do that part 👍 |
It would perhaps be more in line to remove the output. But perhaps it is good to have at least one copy of the output in the git history? Then we can always go back to that version to see what it should approximately look like? It's only 250kb |
I'll merge this. We can remove the output of the notebook later; which does mean it is in the history forever, but it isn't that large to store one version of it. I think we only really need a new package of METIS; could you please make that @teutoburg ? |
So apparently the new IFU example notebook fails with the old ScopeSim. So I probably ran them incorrectly locally and perhaps other METIS notebooks fail too with ScopeSim 0.7.1. But perhaps we can't prevent that. So I'd say that if MICADO runs fine, then it's good enough. |
Counterpart of AstarVienna/ScopeSim#377