fix(mailchimp): prevent merge fields fetch throwing fatal error #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
adekbadek
approved these changes
Dec 5, 2023
github-actions
bot
added
[Status] Approved
dkoo
deleted the
hotfix/mailchimp-connector-check-merge-field-response
branch
matticbot
pushed a commit
that referenced
this pull request
Dec 5, 2023
## [2.6.2](v2.6.1...v2.6.2) (2023-12-05) ### Bug Fixes * **mailchimp:** prevent merge fields fetch throwing fatal error ([#1376](#1376)) ([7d64225](7d64225))
|
🎉 This PR is included in version 2.6.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 5, 2023
# [2.7.0-alpha.3](v2.7.0-alpha.2...v2.7.0-alpha.3) (2023-12-05) ### Bug Fixes * **mailchimp:** prevent merge fields fetch throwing fatal error ([#1376](#1376)) ([7d64225](7d64225))
|
🎉 This PR is included in version 2.7.0-alpha.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Same fix as Automattic/newspack-plugin#2793, but for Newsletters.
How to test the changes in this Pull Request:
$list_id = 'foo'to line 1057 here.release, observe an uncaught error in PHP logs (there won't be any user-facing errors, but the contact won't be added).[NEWSPACK-NEWSLETTERS][Newspack_Newsletters_Subscription::process_subscription_intents]: Error adding contact: Error getting merge fields: The requested resource could not be found.Other information: