fix(mailchimp): prevent merge fields fetch throwing fatal error #2793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This fetch may fail if the audience does not exist in Mailchimp (Resource not found). This change prevents this error from throwing a fatal error and breaking the donation flow.
How to test the changes in this Pull Request:
define( 'NEWSPACK_LOG_LEVEL', 2 );
release
branch confirm the error by adding$audience_id = 'foo';
to line 53 ofincludes/data-events/connectors/class-mailchimp.php
$audience_id = 'foo';
line, and got through the donation flow again[28441][NEWSPACK][Newspack\Data_Events\Connectors\Mailchimp::get_merge_fields]: Error getting merge fields: Resource Not Found
Other information: