Remove Puppeteer references #10352
Merged
Remove Puppeteer references #10352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uppeteer-references
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
…uppeteer-references
allie500
approved these changes
Feb 11, 2025
It can be used later for Slack integration with the E2E tests
This reverts commit 519f89d.
This reverts commit a229eed.
|
Thanks for working on this @eduardoumpierre! I've seen there's still a Puppeteer reference in the package.json: But looks like it's needed for the E2E environment, as it's used by We might need to update the Running tests section from the E2E tests README, as it wrongly says:
It seems this section references to the Puppeteer implementation, so it would be great to adapt it to the Playwright one. I did a first check on the existing |
alopezari
approved these changes
Feb 12, 2025
|
Hey @alopezari! The documentation changes will be made as part of #10354, so it should be addressed soon. Thanks for reviewing this PR! |
…uppeteer-references
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10241
Changes proposed in this Pull Request
This PR aims to remove all Puppeteer files and references. Main changes:
tests/e2e-pwtotests/e2eTesting instructions
E2E Tests - Pull Request,E2E Tests - All, andE2E Tests on Atomic - Allworkflowsnpm run test:e2e-performancetests/e2e/reports/checkout-performance.txtnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge