Update Dispatcher to use Outbox #1186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple rewrite of the current dispatcher system, to use the Outbox instead of the Scheduler. This is a first draft and will be improved over time, to better handle: * Re-tries * Errors * Logging * Batch processing
I'm going to take on some or all of those, let's see how far I get. |
|
@pfefferle I assume we need to get these tests passed? I'd really like this merged into #593 before I bring in my error/logging stuff |
obenland
added a commit
that referenced
this pull request
Jan 21, 2025
obenland
reviewed
Jan 21, 2025
| * Initialize the class, registering WordPress hooks. | ||
| */ | ||
| public static function init() { | ||
| \add_action( 'activitypub_process_outbox', array( self::class, 'process_outbox' ), 10, 1 ); |
There was a problem hiding this comment.
Suggested change
| \add_action( 'activitypub_process_outbox', array( self::class, 'process_outbox' ), 10, 1 ); | |
| \add_action( 'activitypub_process_outbox', array( self::class, 'process_outbox' ) ); |
Priority 10 and 1 accepted arg are defaults.
Comment on lines
+109
to
+110
| $outbox_item->post_status = 'publish'; | ||
| \wp_update_post( $outbox_item ); |
There was a problem hiding this comment.
Suggested change
| $outbox_item->post_status = 'publish'; | |
| \wp_update_post( $outbox_item ); | |
| \wp_publish_post( $outbox_item ); |
I don't know if one is "better" than the other but I wanted to offer it
| @@ -120,8 +120,7 @@ public function get_items( $request ) { | |||
| 'author' => $user_id > 0 ? $user_id : null, | |||
| 'paged' => $page, | |||
| 'post_type' => Outbox::POST_TYPE, | |||
| 'post_status' => 'draft', | |||
|
|
|||
| 'post_status' => 'any', | |||
There was a problem hiding this comment.
Suggested change
| 'post_status' => 'any', | |
| 'post_status' => 'any', | |
You don't want to keep the new line?
obenland
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple dispatcher based on the Outbox-Collection.
This is a simple rewrite of the current dispatcher system, to use the Outbox instead of the Scheduler.
This is a first draft and will be improved over time, to better handle: