Turn Kestrel and AspNetCore into a framework dependency #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
force-pushed
the
dajusto/remove-kestrel-dep
branch
from
a81e5dd to
d5f99d1
Compare
davidmrdavid
changed the title
davidmrdavid
changed the title
davidmrdavid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AspNetCore comes bundled with .NET. As a result, we don't need an explicit package dependency on Kestrel or other AspNetCore packages in the extension. On the contrary, since the NuGet packages for AspNetCore have not been updated in a while, this may lead up to CVEs being flagged for the extension. This PR is an attempt at turning those AspNetCore dependencies into framework dependencies, so that we simply load them from the .NET installation on the machine, just like the Azure Functions Host itself.
Note that this is in response to a customer IcM reporting CVEs in our Kestrel dependency (v2.2.0). Seems the Kestrel package on NuGet is no longer being updated, so this seems like "the only path forward" if we want to appease that request. I may be wrong about that, please let me know. As I know this is a big change, I won't merge until there's an agreement.