Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Kestrel and AspNetCore into a framework dependency #2839

Open
wants to merge 5 commits into
base: v2.x
Choose a base branch
from
Open

Turn Kestrel and AspNetCore into a framework dependency #2839

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17b50bc
use framework dependency in netcoreapp3.1
davidmrdavid May 30, 2024
d5f99d1
add comment
davidmrdavid May 30, 2024
5fdfc69
fix formatting
davidmrdavid May 30, 2024
2754cf7
fix formatting further
davidmrdavid May 30, 2024
876a207
fix typo
davidmrdavid May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,12 @@
<PackageReference Include="Azure.Identity" Version="1.11.0" />
<PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.37" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.WebApiCompatShim" Version="2.2.0" />
<PackageReference Include="Microsoft.AspNetCore.Routing" Version="2.2.0" />
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.2.0" />
<!-- To access Kestrel, use metapackage and leverage framework dependency on AspNetCore.
This allows us to avoid taking dependency on outdated Kestrel packages from NuGet, which may have CVEs-->
<PackageReference Include="Microsoft.AspNetCore.App" />
<PackageReference Include="Microsoft.Extensions.Azure" Version="1.1.1" />
<PackageReference Include="Microsoft.Extensions.Http" Version="2.2.0" />
<PackageReference Include="Microsoft.Azure.DurableTask.ApplicationInsights" Version="0.1.*" />
<!-- Explicitly pinned transitive dependencies with CVE vulnerabilities.-->
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" Version="2.2.1" />
<!-- The gRPC dependencies in this package are not compatible with older frameworks, like .NET Core 2.x -->
<PackageReference Include="Microsoft.DurableTask.Grpc" Version="1.1.0" />
<PackageReference Include="Grpc.Core" Version="2.46.6" /> <!-- Bring this in until we move to hosted RPC -->
Expand Down
Loading