Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update of services.json for files and folders cleaning #318

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

jaimeozaez
Copy link
Member

@jaimeozaez jaimeozaez commented Aug 19, 2024

Updated the rest of pipelines configuration in services.json for proper cleaning of folders and files.

Closes #223

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

@jaimeozaez jaimeozaez self-assigned this Aug 19, 2024
@jaimeozaez jaimeozaez marked this pull request as ready for review August 19, 2024 15:56
Copy link
Member

@saramonzon saramonzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
We need to remember to check everything is deleted properly when we have one of these services, to make sure

@jaimeozaez jaimeozaez merged commit fd69fcc into BU-ISCIII:develop Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants