Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-267/Sylius 1.12 and 1.13 support #27

Merged
merged 30 commits into from
May 22, 2024

Conversation

marekrzytki
Copy link
Contributor

@marekrzytki marekrzytki commented May 14, 2024

This PR includes:

  • drop support for PHP 7.4
  • drop support for Sylius 1.9 - 1.11
  • drop support for Symfony 4.4
  • add support for Sylius 1.12 - 1.13
  • add support for Symfony 6.0
  • update BitBag coding standard

Copy link
Member

@senghe senghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve in advance.

php: ["8.0", "7.4"]
symfony: ["^4.4", "^5.2"]
sylius: ["~1.9.6", "~1.10.0", "~1.11.0"]
php: ["8.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 8.1 and 8.2?

php: ["8.0", "7.4"]
symfony: ["^4.4", "^5.2"]
sylius: ["~1.9.6", "~1.10.0", "~1.11.0"]
php: ["8.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.1 and 8.2?

composer.json Outdated
"php": "^7.4 || ^8.0",
"sylius/sylius": "~1.9.0 || ~1.10.0 || ~1.11.0",
"twig/inky-extra": "^3.3"
"php": "^8.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^8.1?

@@ -0,0 +1,13 @@
version: '3.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write in README.md or similar, how to test the e-mails

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the docker-compose -f DIR/docker-compose.mailhog.yaml up command and the ports mapping information.

@marekrzytki marekrzytki merged commit ff05b95 into master May 22, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants