-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP-267/Sylius 1.12 and 1.13 support #27
Conversation
- security - mailer - kernel
…sion to master for php support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve in advance.
.github/workflows/build.yml
Outdated
php: ["8.0", "7.4"] | ||
symfony: ["^4.4", "^5.2"] | ||
sylius: ["~1.9.6", "~1.10.0", "~1.11.0"] | ||
php: ["8.2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 8.1 and 8.2?
php: ["8.0", "7.4"] | ||
symfony: ["^4.4", "^5.2"] | ||
sylius: ["~1.9.6", "~1.10.0", "~1.11.0"] | ||
php: ["8.2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.1 and 8.2?
composer.json
Outdated
"php": "^7.4 || ^8.0", | ||
"sylius/sylius": "~1.9.0 || ~1.10.0 || ~1.11.0", | ||
"twig/inky-extra": "^3.3" | ||
"php": "^8.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^8.1?
@@ -0,0 +1,13 @@ | |||
version: '3.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write in README.md or similar, how to test the e-mails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the docker-compose -f DIR/docker-compose.mailhog.yaml up
command and the ports mapping information.
This PR includes: