OP-267/Sylius 1.12 and 1.13 support #27
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| version: '3.4' | ||
|
There was a problem hiding this comment. I would write in README.md or similar, how to test the e-mails There was a problem hiding this comment. I mean the |
||
|
|
||
| services: | ||
| mailhog: | ||
| # do not use in production! | ||
| image: mailhog/mailhog:latest | ||
| environment: | ||
| - MH_STORAGE=maildir | ||
| # volumes: | ||
| # - ./docker/mailhog/maildir:/maildir:rw,delegated | ||
| ports: | ||
| - "8025:8025" | ||
| - "1025:1025" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,13 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| use Symplify\EasyCodingStandard\Config\ECSConfig; | ||
|
|
||
| return static function (ECSConfig $config): void { | ||
|
|
||
| putenv('ALLOW_BITBAG_OS_HEADER=1'); | ||
|
|
||
| $config->import('vendor/bitbag/coding-standard/ecs.php'); | ||
| $config->paths(['src', 'spec', 'tests/Repository', 'tests/Behat']); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ Feature: Receiving confirmation email after finalizing checkout | |
|
|
||
| @ui @email | ||
| Scenario: Receiving a custom confirmation email after finalizing checkout | ||
| Given there is mail template with "order_confirmation" type and "Order confirmation" name and "Congratulations, you have bought new gun" subject and "Pif paf {{order.number}}" content | ||
| And I have product "Sig Sauer P226" in the cart | ||
| And I have completed addressing step with email "[email protected]" and "United States" based billing address | ||
| And I have proceeded order with "Free" shipping method and "Offline" payment | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ Feature: Receiving set of welcoming emails after registration | |
|
|
||
| @ui @email | ||
| Scenario: Receiving a custom welcoming email after registration | ||
| Given there is mail template with "verification_token" type and "User registration" name and "Welcome to our shop!" subject and "Enjoy our stuff!" content | ||
| When I register with email "[email protected]" and password "suitsarelife" | ||
| Then a welcoming email should have been sent to "[email protected]" | ||
|
|
||
|
|
@@ -24,7 +24,7 @@ Feature: Receiving set of welcoming emails after registration | |
| When I register with email "[email protected]" and password "suitsarelife" | ||
| Then I should be notified that my account has been created and the verification email has been sent | ||
| And a default account verification email should have been sent to "[email protected]" | ||
| And emails should be sent to "[email protected]" depending on Sylius version | ||
| But I should not be able to log in as "[email protected]" with "suitsarelife" password | ||
|
|
||
| @ui @email | ||
|
|
@@ -33,5 +33,5 @@ Feature: Receiving set of welcoming emails after registration | |
| When I register with email "[email protected]" and password "suitsarelife" | ||
| Then I should be notified that my account has been created and the verification email has been sent | ||
| And a custom account verification email should have been sent to "[email protected]" | ||
| And emails should be sent to "[email protected]" depending on Sylius version | ||
| But I should not be able to log in as "[email protected]" with "suitsarelife" password | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,9 @@ | ||
| includes: | ||
| - vendor/bitbag/coding-standard/phpstan.neon | ||
| parameters: | ||
| level: 8 | ||
| excludePaths: | ||
| - tests/Repository | ||
| paths: | ||
| - src | ||
| - tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file has been created by developers from BitBag. | ||
| * Feel free to contact us once you face any issues or want to start | ||
| * You can find more information about us on https://bitbag.io and write us | ||
| * an email on [email protected]. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
@@ -41,14 +42,14 @@ function it_is_initializable( | |
| SenderAdapterInterface $senderAdapter, | ||
| EmailProviderInterface $provider, | ||
| DefaultSettingsProviderInterface $defaultSettingsProvider, | ||
| EmailTemplateTranslationRepositoryInterface $templateTranslationRepository, | ||
| ): void { | ||
| $this->beConstructedWith( | ||
| $rendererAdapter, | ||
| $senderAdapter, | ||
| $provider, | ||
| $defaultSettingsProvider, | ||
| $templateTranslationRepository, | ||
| ); | ||
| $this->shouldHaveType(Sender::class); | ||
| } | ||
|
|
@@ -60,7 +61,7 @@ function it_should_send_email( | |
| DefaultSettingsProviderInterface $defaultSettingsProvider, | ||
| EmailTemplateTranslationRepositoryInterface $templateTranslationRepository, | ||
| EmailInterface $email, | ||
| RenderedEmail $renderedEmail, | ||
| ): void { | ||
| $this->beConstructedWith( | ||
| $rendererAdapter, | ||
|
|
@@ -102,7 +103,7 @@ function it_should_set_custom_email_template_if_found( | |
| DefaultSettingsProviderInterface $defaultSettingsProvider, | ||
| EmailTemplateTranslationRepositoryInterface $templateTranslationRepository, | ||
| EmailInterface $email, | ||
| RenderedEmail $renderedEmail, | ||
| ): void { | ||
| $this->beConstructedWith( | ||
| $rendererAdapter, | ||
|
|
@@ -122,7 +123,7 @@ function it_should_set_custom_email_template_if_found( | |
| $emailTemplateTranslation = new EmailTemplateTranslation(); | ||
| $templateTranslationRepository->findOneByLocaleCodeAndType( | ||
| self::LOCALE, | ||
| self::EMAIL_TYPE, | ||
| )->willReturn($emailTemplateTranslation); | ||
|
|
||
| $rendererAdapter->render($email, Argument::type('array'))->willReturn($renderedEmail); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file has been created by developers from BitBag. | ||
| * Feel free to contact us once you face any issues or want to start | ||
| * You can find more information about us on https://bitbag.io and write us | ||
| * an email on [email protected]. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
@@ -15,7 +16,6 @@ | |
| use PhpSpec\ObjectBehavior; | ||
| use Prophecy\Argument; | ||
| use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface; | ||
| use Symfony\Component\HttpFoundation\RedirectResponse; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
| use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface; | ||
|
|
@@ -31,7 +31,7 @@ function let( | |
| DataCollectorTranslator $dataCollectorTranslator, | ||
| RouterInterface $router, | ||
| Request $request, | ||
| ParameterBagInterface $attributes, | ||
| ): void { | ||
| $request->attributes = $attributes; | ||
|
|
||
|
|
@@ -46,10 +46,12 @@ function it_is_initializable(): void | |
| function it_should_do_nothing_when_route_is_not_create_email_template( | ||
| RequestEvent $requestEvent, | ||
| Request $request, | ||
| ParameterBagInterface $attributes, | ||
| EmailCodesProviderInterface $emailCodesProvider, | ||
| Session $session, | ||
| ): void { | ||
| $requestEvent->getRequest()->willReturn($request); | ||
| $request->getSession()->willReturn($session); | ||
|
|
||
| $attributes->get('_route')->shouldBeCalled()->willReturn('wrong_route'); | ||
|
|
||
|
|
@@ -61,10 +63,10 @@ function it_should_do_nothing_when_route_is_not_create_email_template( | |
| function it_should_not_redirect_when_type_are_available_to_create_email_template( | ||
| RequestEvent $requestEvent, | ||
| Request $request, | ||
| ParameterBagInterface $attributes, | ||
| EmailCodesProviderInterface $emailCodesProvider, | ||
| Session $session, | ||
| FlashBagInterface $flashBag, | ||
| ): void { | ||
| $requestEvent->getRequest()->willReturn($request); | ||
|
|
||
|
|
@@ -85,12 +87,12 @@ function it_should_not_redirect_when_type_are_available_to_create_email_template | |
| function it_should_redirect_when_route_is_create_email_template( | ||
| RequestEvent $requestEvent, | ||
| Request $request, | ||
| ParameterBagInterface $attributes, | ||
| EmailCodesProviderInterface $emailCodesProvider, | ||
| Session $session, | ||
| FlashBagInterface $flashBag, | ||
| RouterInterface $router, | ||
| DataCollectorTranslator $dataCollectorTranslator, | ||
| ): void { | ||
| $requestEvent->getRequest()->willReturn($request); | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 8.1 and 8.2?