prompt user on non-whitelisted hosts #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
user_verify
branch
2 times, most recently
from
f11c4a8
to
0dee604
Compare
Maintaining a whitelist in the binary does not scale and might put off third party devs. For a host that is not in the whitelist, we instead prompt the user if they want to accept the connection. Since we already run a server, we simply launch the browser on confirmation page served by our server. It is a bit weird UX, but it was the easiest solution I could find that works everywhere. Alternatives considered: - native dialogs using rfd - unfortunately does not work on macOS as the main process is windowless - native dialogs using SDL: looks extremely ugly, hard to figure out deployment - use Rust's Tauri or Qt or similar for native UIs: hard to deploy
Added basic BitBox styling. The HTML file is self contained and only uses inline styles and inline svg graphics.
|
@NickeZ switched to using a uuid in a separate commit for easy review. I'll squash it in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining a whitelist in the binary does not scale and might put off
third party devs.
For a host that is not in the whitelist, we instead prompt the user if
they want to accept the connection.
Since we already run a server, we simply launch the browser on
confirmation page served by our server. It is a bit weird UX, but it
was the easiest solution I could find that works everywhere.
Alternatives considered:
the main process is windowless