Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt user on non-whitelisted hosts #51

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Commits on Jul 3, 2024

  1. prompt user on non-whitelisted hosts

    Maintaining a whitelist in the binary does not scale and might put off
    third party devs.
    
    For a host that is not in the whitelist, we instead prompt the user if
    they want to accept the connection.
    
    Since we already run a server, we simply launch the browser on
    confirmation page served by our server. It is a bit weird UX, but it
    was the easiest solution I could find that works everywhere.
    
    Alternatives considered:
    - native dialogs using rfd - unfortunately does not work on macOS as
      the main process is windowless
    - native dialogs using SDL: looks extremely ugly, hard to figure out deployment
    - use Rust's Tauri or Qt or similar for native UIs: hard to deploy
    benma committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    fba8738 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. bridge: user confirmation styling

    Added basic BitBox styling. The HTML file is self contained and
    only uses inline styles and inline svg graphics.
    thisconnect committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4f67f34 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. use uuid instead of counter

    benma committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    849a2be View commit details
    Browse the repository at this point in the history