Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check multithreading only for python plugin functions #127

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

martaiborra
Copy link
Collaborator

@martaiborra martaiborra commented Aug 1, 2023

This lets use multithreading for user-defined plugins when the corresponding functions are not Python functions.

Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If not there yet, I'd suggest to add a couple of tests, one when using a Python codec with nthreads > 1, and other for a Python filter.

Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@FrancescAlted FrancescAlted merged commit f2c6ea3 into main Aug 1, 2023
9 checks passed
@FrancescAlted FrancescAlted deleted the dyn_plugins branch August 1, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants