Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check multithreading only for python plugin functions #127

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Check multithreading only for python plugin functions #127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f282a8
Check multithreading only for python plugin functions
martaiborra Aug 1, 2023
e172939
Add tests
martaiborra Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions blosc2/blosc2_ext.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,24 +646,34 @@ def get_blocksize():

cdef _check_cparams(blosc2_cparams *cparams):
if cparams.nthreads > 1:
if BLOSC2_USER_REGISTERED_CODECS_START <= cparams.compcode <= BLOSC2_USER_REGISTERED_CODECS_STOP:
raise ValueError("Cannot use multi-threading with user defined codecs")
elif any([BLOSC2_USER_REGISTERED_FILTERS_START <= filter <= BLOSC2_USER_REGISTERED_FILTERS_STOP
for filter in cparams.filters]):
raise ValueError("Cannot use multi-threading with user defined filters")
elif cparams.prefilter != NULL:
if BLOSC2_USER_REGISTERED_CODECS_START <= cparams.compcode <= BLOSC2_USER_REGISTERED_CODECS_STOP\
and cparams.compcode in blosc2.ucodecs_registry.keys():
raise ValueError("Cannot use multi-threading with user defined Python codecs")

ufilters = [BLOSC2_USER_REGISTERED_FILTERS_START <= filter <= BLOSC2_USER_REGISTERED_FILTERS_STOP
for filter in cparams.filters]
for i in range(len(ufilters)):
if ufilters[i] and cparams.filters[i] in blosc2.ufilters_registry.keys():
raise ValueError("Cannot use multi-threading with user defined Python filters")

if cparams.prefilter != NULL:
raise ValueError("`nthreads` must be 1 when a prefilter is set")

cdef _check_dparams(blosc2_dparams* dparams, blosc2_cparams* cparams=NULL):
if cparams == NULL:
return
if dparams.nthreads > 1:
if BLOSC2_USER_REGISTERED_CODECS_START <= cparams.compcode <= BLOSC2_USER_REGISTERED_CODECS_STOP:
raise ValueError("Cannot use multi-threading with user defined codecs")
elif any([BLOSC2_USER_REGISTERED_FILTERS_START <= filter <= BLOSC2_USER_REGISTERED_FILTERS_STOP
for filter in cparams.filters]):
raise ValueError("Cannot use multi-threading with user defined filters")
elif dparams.postfilter != NULL:
if BLOSC2_USER_REGISTERED_CODECS_START <= cparams.compcode <= BLOSC2_USER_REGISTERED_CODECS_STOP\
and cparams.compcode in blosc2.ucodecs_registry.keys():
raise ValueError("Cannot use multi-threading with user defined Python codecs")

ufilters = [BLOSC2_USER_REGISTERED_FILTERS_START <= filter <= BLOSC2_USER_REGISTERED_FILTERS_STOP
for filter in cparams.filters]
for i in range(len(ufilters)):
if ufilters[i] and cparams.filters[i] in blosc2.ufilters_registry.keys():
raise ValueError("Cannot use multi-threading with user defined Python filters")

if dparams.postfilter != NULL:
raise ValueError("`nthreads` must be 1 when a postfilter is set")


Expand Down
Loading