Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Have Screen Speak/screen readers on mobile read Journey before other page content. #1088

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

adamerickson-branch
Copy link
Contributor

@adamerickson-branch adamerickson-branch commented Nov 8, 2024

Pull Request Template

Description

For mobile, changed appendChild to prepend so the journey is at the top of the HTML and is read first by screen readers.

Fixes # (issue)
ENGMT-1629

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test
  • Manual testing. Journey's unit tests are commented out (have been for years it looks like?). Manual testing videos are visible in the JIRA ticket.

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js. 166KB 166KB
dist/build.min.js 77KB 77KB

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

@adamerickson-branch adamerickson-branch marked this pull request as ready for review November 12, 2024 18:50
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Test Results

  1 files  ±0    1 suites  ±0   54s ⏱️ -5s
159 tests ±0  152 ✅ ±0  7 💤 ±0  0 ❌ ±0 
162 runs  ±0  155 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit deab75a. ± Comparison against base commit 9043225.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@bredmond5 bredmond5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamerickson-branch adamerickson-branch merged commit ef478c7 into master Nov 12, 2024
5 checks passed
@adamerickson-branch adamerickson-branch deleted the feat/move_to_to_of_body branch November 12, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants