User story9 #101
Closed
User story9 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User Story 9, Registration Email must be unique #74 |
| @@ -31,6 +34,12 @@ def edit | |||
|
|
|||
| private | |||
|
|
|||
| def email_confirmation | |||
| User.email_string.all? do |email| | |||
There was a problem hiding this comment.
Could you just use an .include? here?
WHomer
approved these changes
May 22, 2019
| user_2 = User.create!(name: "default_user1", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", state: "CO", zip: "80000", email: "[email protected]" ) | ||
| user_3 = User.create!(name: "default_user2", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", state: "CO", zip: "80000", email: "[email protected]" ) | ||
|
|
||
| expect(User.email_string).not_to eq(["[email protected]", "[email protected]", "[email protected]"]) |
There was a problem hiding this comment.
Should we have a positive expectation as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added email confirmation method and verified the test was passing.
Added tests in models and new user spec.
Added test for password confirmation.