User story9

app/controllers/users_controller.rb

@@ -9,9 +9,12 @@ def new
   def create
     @user = User.new(strong_params)
     if password_confirmation != true
+      flash[:notice] = "Those passwords don't match."
       render :new
-      flash[:notice] = "Those passwords don't match"
-    elsif @user.save
+    elsif email_confirmation != true
+      flash[:notice] = "That email address is already taken."
+      render :new
+    elsif @user.save!
       session[:user_id] = @user.id
       flash[:notice] = "You are now registered and logged in."
       redirect_to profile_path
@@ -31,6 +34,12 @@ def edit
 
   private
 
+  def email_confirmation
+    User.email_string.all? do |email|
+      params[:user][:email] != email
+    end
+  end
+
   def password_confirmation
     if params["user"]["password"] == params["user"]["confirm_password"]
       true

app/models/user.rb

@@ -9,4 +9,8 @@ class User < ApplicationRecord
   has_secure_password
 
   enum role: ["default", "merchant", "admin"]
+
+  def self.email_string
+    pluck(:email)
+  end
 end

spec/features/users/new_spec.rb

@@ -5,7 +5,7 @@
     describe 'When I visit the register new register link' do
 
       before :each do
-        @user_1 = User.create!(name: "default_user", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", zip: "80000", email: "[email protected]", state: 'IL' )
+        @user_1 = User.create!(name: "default_user", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", state: "CO", zip: "80000", email: "[email protected]" )
       end
 
       it 'I can register as a new user' do
@@ -45,8 +45,58 @@
 
       end
 
-      it 'Can not use an already used email address' do
-        user_2 = User.create!(name: "User_1", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", zip: "80000", email: "[email protected]", state: 'IL' )
+      it 'I throws flash message when password isnt the same' do
+
+
+        visit root_path
+
+        within '.register-link' do
+          click_link('Register')
+        end
+
+        expect(current_path).to eq(register_path)
+
+        fill_in 'Name', with: 'User'
+        fill_in 'Address', with: '1111 South One St.'
+        fill_in 'City', with: 'Denver'
+        fill_in 'State', with: 'CO'
+        fill_in 'Zip', with: '80000'
+        fill_in 'Email', with: '[email protected]'
+        fill_in 'Password', with: 'password'
+        fill_in 'Confirm password', with: 'password3'
+
+        click_button 'Create User'
+
+
+        new_user = User.last
+
+
+        expect(current_path).to eq(register_path)
+
+        expect(page).to have_content("Those passwords don't match.")
+
+      end
+
+      it 'Can not use a duplicate email address' do
+
+        visit root_path
+
+        within '.register-link' do
+          click_link('Register')
+        end
+
+
+        fill_in 'Name', with: 'User_1'
+        fill_in 'Address', with: '1111 South One St.'
+        fill_in 'City', with: 'Denver'
+        fill_in 'State', with: 'CO'
+        fill_in 'Zip', with: '80000'
+        fill_in 'Email', with: '[email protected]'
+        fill_in 'Password', with: 'password'
+        fill_in 'Confirm password', with: 'password'
+
+        click_button 'Create User'
+
         visit root_path
 
         within '.navbar' do
@@ -65,9 +115,13 @@
         click_button 'Create User'
 
         new_user = User.last
-
+        expect(page).to have_content("That email address is already taken.")
         expect(new_user.name).to eq('User_1')
       end
     end
   end
 end
+
+# My details are not saved and I am not logged in
+# The form is filled in with all previous data except the email field and password fields
+# I see a flash message telling me the email address is already in use

spec/models/user_spec.rb

@@ -19,4 +19,15 @@
 
     it { should validate_uniqueness_of :email }
   end
+
+  describe 'class methods' do
+
+    it 'email_string' do
+      user_1 = User.create!(name: "default_user", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", state: "CO", zip: "80000", email: "[email protected]" )
+      user_2 = User.create!(name: "default_user1", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", state: "CO", zip: "80000", email: "[email protected]" )
+      user_3 = User.create!(name: "default_user2", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", state: "CO", zip: "80000", email: "[email protected]" )
+
+      expect(User.email_string).not_to eq(["[email protected]", "[email protected]", "[email protected]"])
+    end
+  end
 end