tz: add TimeZone::try_system
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API is like `TimeZone::system`, but turns "get system configured time zone" into a fallible operation instead of automatically falling back to UTC. The error message here is pretty generic and uninformative. All of the interesting bits are emitting as log messages. In #65, I talked about improving this, but it's not quite clear the best way to do that. I think we'd probably need to invent some smarter infrastructure for collecting a "trace" of what was attempted, and then either emit them as log messages or tie them up into a single error message. But the latter case could result in a very big error message. So for now, this just returns a pretty generic error message, but all of the log statements are still there for when you need to understand more deeply what went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is like
TimeZone::system, but turns "get system configuredtime zone" into a fallible operation instead of automatically falling
back to UTC.
The error message here is pretty generic and uninformative. All of the
interesting bits are emitting as log messages. In #65, I talked about
improving this, but it's not quite clear the best way to do that. I
think we'd probably need to invent some smarter infrastructure for
collecting a "trace" of what was attempted, and then either emit them as
log messages or tie them up into a single error message. But the latter
case could result in a very big error message.
So for now, this just returns a pretty generic error message, but all of
the log statements are still there for when you need to understand more
deeply what went wrong.