Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tz: add TimeZone::try_system #123

Merged
merged 1 commit into from
Aug 31, 2024
Merged

tz: add TimeZone::try_system #123

merged 1 commit into from
Aug 31, 2024

Commits on Aug 31, 2024

  1. tz: add TimeZone::try_system

    This API is like `TimeZone::system`, but turns "get system configured
    time zone" into a fallible operation instead of automatically falling
    back to UTC.
    
    The error message here is pretty generic and uninformative. All of the
    interesting bits are emitting as log messages. In #65, I talked about
    improving this, but it's not quite clear the best way to do that. I
    think we'd probably need to invent some smarter infrastructure for
    collecting a "trace" of what was attempted, and then either emit them as
    log messages or tie them up into a single error message. But the latter
    case could result in a very big error message.
    
    So for now, this just returns a pretty generic error message, but all of
    the log statements are still there for when you need to understand more
    deeply what went wrong.
    BurntSushi committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    a11b1d5 View commit details
    Browse the repository at this point in the history