Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Path to Save Current Game and Load Arbitrary Saves #426

Open
wants to merge 7 commits into
base: pcen/save-types-without-references
Choose a base branch
from

Conversation

pcen
Copy link
Contributor

@pcen pcen commented Sep 20, 2023

to save the current game: ctrl + s -> saves to hardcoded path ./Text/save.json (if running Godot from the command line, invoke in C7 subfolder)

can now load .sav as well as .json files from main menu

@pcen pcen changed the title save running games Code Path to Save Current Game and Load Arbitrary Saves Sep 25, 2023
@pcen pcen marked this pull request as ready for review September 25, 2023 02:01
@@ -0,0 +1,34 @@
[remap]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently we should check all *.import files into source, but not Godot's .import folder

@QuintillusCFC QuintillusCFC added the save-game PRs/issues related to save games label Mar 22, 2024
@WildWeazel
Copy link
Member

@pcen This one slipped through the cracks- what's the status of this branch? Did these changes make it into godot4 when you split out your save work? If not there are likely conflicts by now, and maybe some redundancy.

@pcen
Copy link
Contributor Author

pcen commented Dec 8, 2024

It's not merged. I think it was mostly UI change to allow loading and saving different saves, I don't think it added too much functionality. We should re-base if necessary and merge into Godot 4 branch

@WildWeazel WildWeazel changed the base branch from pcen/save-types-without-references to godot4 December 9, 2024 03:21
@WildWeazel WildWeazel changed the base branch from godot4 to pcen/save-types-without-references December 9, 2024 03:24
@WildWeazel
Copy link
Member

This did not make it into the Carthage merge (though technically that ship hasn't sailed yet...) as there are significant conflicts between it and godot4 by this point, and I don't know enough about it to sort it out. This along with the tilemaps branch should be prioritized next before they get any further behind.

@WildWeazel WildWeazel added help wanted Extra attention is needed godot4 PRs targeting Godot 4 branch labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
godot4 PRs targeting Godot 4 branch help wanted Extra attention is needed save-game PRs/issues related to save games
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants