Use a (local) test DB for load tests so it doesn't wipe out the regular local DB #1074
Conversation
|
| POSTGRES_PASSWORD: "changeIT!" # pragma: allowlist secret | ||
| POSTGRES_USER: "intermediary" | ||
| ports: | ||
| - 5434:5432 |
There was a problem hiding this comment.
Is it supposed to be 5432:5434?
There was a problem hiding this comment.
The non-test version is 5433:5432, so this is just incrementing the 5433 to match. I think the first number is the Docker host port (so what any services on your machine or a DB client or whatever would connect to) and the second is the container's port inside docker. Since the two DBs (intermediary and intermediary-test) are running on different containers, it's okay they're both using 5432 (the default postgres port), and then the 5434 is what the load tests connect to
| @@ -4,8 +4,8 @@ set -e | |||
| start_api() { | |||
| echo 'Starting API' | |||
| export DB_URL=localhost | |||
| export DB_PORT=5433 | |||
| export DB_NAME=intermediary | |||
| export DB_PORT=5434 | |||
There was a problem hiding this comment.
Why was this port changed to 5434?
There was a problem hiding this comment.
so that if you have the regular local DB already up and running, this won't conflict with or kill it
Use a (local) test DB for load tests so it doesn't wipe out the regular local DB
Add a
docker-compose.postgres-test.ymlfile that sets up anintermediary-testDB and have the load tests use that DB - then the regular localintermediaryDB won't be wiped out by running load testsIssue
#1044.
Checklist