Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a (local) test DB for load tests so it doesn't wipe out the regular local DB #1074

Merged
merged 3 commits into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ running...
```

This will run the API for you, so no need to run it manually.
**If you are already running the API, stop it before running the load tests or the cleanup steps won't work.**
The load tests will also spin up (and clean up) a local test DB on port 5434 that should not interfere with the local dev DB.

The `locustfile.py` that specifies the load test is located at
[`./operations/locustfile.py`](./operations/locustfile.py).
Expand Down
17 changes: 17 additions & 0 deletions docker-compose.postgres-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
version: "3.7"

services:
postgresql-test:
image: postgres:16
restart: unless-stopped
environment:
POSTGRES_DB: "intermediary-test"
POSTGRES_PASSWORD: "changeIT!" # pragma: allowlist secret
POSTGRES_USER: "intermediary"
ports:
- 5434:5432
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it supposed to be 5432:5434?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-test version is 5433:5432, so this is just incrementing the 5433 to match. I think the first number is the Docker host port (so what any services on your machine or a DB client or whatever would connect to) and the second is the container's port inside docker. Since the two DBs (intermediary and intermediary-test) are running on different containers, it's okay they're both using 5432 (the default postgres port), and then the 5434 is what the load tests connect to

volumes:
- ti_postgres_test_data:/var/lib/postgresql/data

volumes:
ti_postgres_test_data:
14 changes: 7 additions & 7 deletions load-execute.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ set -e
start_api() {
echo 'Starting API'
export DB_URL=localhost
export DB_PORT=5433
export DB_NAME=intermediary
export DB_PORT=5434
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this port changed to 5434?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so that if you have the regular local DB already up and running, this won't conflict with or kill it

export DB_NAME=intermediary-test
export DB_USER=intermediary
export DB_PASS=changeIT!
export DB_SSL=require
Expand All @@ -16,14 +16,14 @@ start_api() {

start_database() {
echo 'Starting database'
docker compose -f docker-compose.postgres.yml up -d
docker compose -f docker-compose.postgres-test.yml up -d
sleep 2
echo "Database started"
}

migrate_database() {
echo 'Migrating database'
liquibase update --changelog-file ./etor/databaseMigrations/root.yml --url jdbc:postgresql://localhost:5433/intermediary --username intermediary --password 'changeIT!' --label-filter '!azure'
liquibase update --changelog-file ./etor/databaseMigrations/root.yml --url jdbc:postgresql://localhost:5434/intermediary-test --username intermediary --password 'changeIT!' --label-filter '!azure'
echo "Database migrated"
}

Expand Down Expand Up @@ -54,9 +54,9 @@ cleanup() {
kill "${API_PID}"
echo "PID ${API_PID} killed"
echo "Stopping and deleting database"
docker stop trusted-intermediary-postgresql-1
docker rm -f trusted-intermediary-postgresql-1
docker volume rm trusted-intermediary_ti_postgres_data
docker stop trusted-intermediary-postgresql-test-1
docker rm -f trusted-intermediary-postgresql-test-1
docker volume rm trusted-intermediary_ti_postgres_test_data
echo "Database stopped and deleted"
}

Expand Down
Loading