This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
Create Azure storage account and container to store HL7 files for automated testing #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
basiliskus
changed the title
4 tasks
halprin
reviewed
Sep 3, 2024
| @@ -55,3 +55,45 @@ resource "azurerm_role_assignment" "allow_api_read_write" { | |||
| role_definition_name = "Storage Blob Data Contributor" | |||
| principal_id = azurerm_linux_web_app.api.identity.0.principal_id | |||
| } | |||
|
|
|||
| resource "azurerm_storage_account" "automated_storage" { | |||
There was a problem hiding this comment.
Can you set this storage account with encryption with our customer managed key? You can take inspiration from CDCgov/reportstream-sftp-ingestion#144
There was a problem hiding this comment.
I'm adding the azurerm_storage_account_customer_managed_key for the new container. Do I also need to add a new azurerm_key_vault_access_policy unique to this new container? Similar to azurerm_key_vault_access_policy.allow_storage_storage_account_wrapping?
There was a problem hiding this comment.
I just added the changes here: f91a4fa
basiliskus
changed the title
|
jcrichlake
approved these changes
Sep 4, 2024
tjohnson7021
pushed a commit
that referenced
this pull request
Oct 17, 2024
…omated testing (#1280) * Added initial terraform config for sftp storage * Create buckets for initial and final hl7 files. Disabled SFTP as we may not use it * Added role assignment. Still need to figure out the principal_id * Updated principal_id to var.deployer_id * Added customer managed key for new container * Commenting code as workaround for order of execution issue with terraform apply * Uncommenting code to apply changes --------- Co-authored-by: halprin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Azure storage account and container to store HL7 files for automated testing
This PR creates an Azure storage account to use for the RS automated integration tests. It creates one container where we'll store the final HL7 files uploaded by RS at the end of the message flow
Issue
#1255