This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 10
Create Azure storage account and container to store HL7 files for automated testing #1280
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
85c0e1b
Added initial terraform config for sftp storage
basiliskus b4dcf7c
Create buckets for initial and final hl7 files. Disabled SFTP as we m…
basiliskus 75ccc4e
Added role assignment. Still need to figure out the principal_id
basiliskus 1279799
Updated principal_id to var.deployer_id
basiliskus a82f20b
Merge branch 'main' into story/1255/add-azure-storage-account
halprin bb93e7f
Merge branch 'main' into story/1255/add-azure-storage-account
halprin 3f90bb0
Merge branch 'main' into story/1255/add-azure-storage-account
basiliskus f91a4fa
Added customer managed key for new container
basiliskus 8ffcaa9
Commenting code as workaround for order of execution issue with terra…
basiliskus d8e6fce
Uncommenting code to apply changes
basiliskus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you set this storage account with encryption with our customer managed key? You can take inspiration from CDCgov/reportstream-sftp-ingestion#144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding the
azurerm_storage_account_customer_managed_key
for the new container. Do I also need to add a newazurerm_key_vault_access_policy
unique to this new container? Similar toazurerm_key_vault_access_policy.allow_storage_storage_account_wrapping
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the changes here: f91a4fa