generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e/1452/map local and loinc codes #1515
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c1c4243
skeleton
jorg3lopez 90328a8
Add LOINC and PLT tests
jbiskie 91faa6d
Renumber tests
jbiskie da92294
Merge remote-tracking branch 'origin/main' into e2e/1452/map-local-an…
jbiskie 6a415ad
Adding pipes to end of MSH segments
jbiskie c6a6bed
Added more delimeters after HL7 version number to try fix the issue p…
basiliskus 9407c9f
Fixed typo
basiliskus 52c9d65
Updated OBR-4.1 expectation for UCSD
basiliskus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
MSH|^~\&|SISGDSP|SISGDSP|SISHIERECEIVER^11903029^L,M,N|^automated-staging-test-receiver-id^L,M,N|20240226034304||ORU^R01^ORU_R01|006|N|2.5.1 | ||
PID|1||80008836^^^&NPI^MR||CDPHSIX^BOY MOMSIX^^^^^B|||M||2106-3^White||||||||||||2186-5^Not Hispanic or Latino||N|1 | ||
NK1|1|CDPHSIX|MTH^Mother|132 ST^^SAN DIEGO^CA^92126^USA | ||
ORC|RE|7181233072^FormNumber||189430284^HospOrdNumber||||||||^ROSEN^REBECCA|||||||||UCSD JACOBS MEDICAL CENTER^^^^^^^^^R797| 2961DR YLLUT^^SAN DIEGO^CA^99999-9999 | ||
OBR|1|7181233072^FormNumber||54089-8^NB Screen Panel Patient AHIC|||202402131546|||||||||^JOHNSON^KATHRYN||||||20240226034304|||F | ||
OBR|2|7181233072^FormNumber||57128-1^Newborn Screening Report summary panel|||202402131546|||||||||^JOHNSON^KATHRYN||||||20240226034304|||F | ||
OBX|1|CE|^^^99717-32^Adrenoleukodystrophy deficiency newborn screening interpretation^L|1|LA18592-8^In range^LN|||N|||F|||20240226034304 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
MSH|^~\&|SISGDSP|SISGDSP|SISHIERECEIVER^11903029^L,M,N|^automated-staging-test-receiver-id^L,M,N|20240226034304||ORU^R01^ORU_R01|007|N|2.5.1 | ||
PID|1||80008836^^^&NPI^MR||CDPHSIX^BOY MOMSIX^^^^^B|||M||2106-3^White||||||||||||2186-5^Not Hispanic or Latino||N|1 | ||
NK1|1|CDPHSIX|MTH^Mother|132 ST^^SAN DIEGO^CA^92126^USA | ||
ORC|RE|7181233072^FormNumber||189430284^HospOrdNumber||||||||^ROSEN^REBECCA|||||||||UCSD JACOBS MEDICAL CENTER^^^^^^^^^R797| 2961DR YLLUT^^SAN DIEGO^CA^99999-9999 | ||
OBR|1|7181233072^FormNumber||54089-8^NB Screen Panel Patient AHIC|||202402131546|||||||||^JOHNSON^KATHRYN||||||20240226034304|||F | ||
OBR|2|7181233072^FormNumber||57128-1^Newborn Screening Report summary panel|||202402131546|||||||||^JOHNSON^KATHRYN||||||20240226034304|||F | ||
OBX|1|TX|^^^99717-60^SMN1 Homozygous Deletion Analysis^L|1|Exon 7 Absent||Exon 7 Present|A|||F|||20240226034304 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running the assertions on these files but for some reason the Hapi library is not able to parse them. It triggers an error when trying to parse the 2.5.1 version number:
ca.uhn.hl7v2.HL7Exception: The HL7 version 2.5.1\nPID is not recognized
. I also noticed the files Gilmore added are not getting parsed either. Could you try adding a|
after2.5.1
? That may fix itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the 4 files. Could you try them again? *Also, what's your process for running the assertions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run the
Automated Staging Test - Submit Messages
github workflow on the branch to send the new files to RS staging. You can then check they are delivered to the RS blob storage accountcdctiautomatedstg
(you need to log in to your -SU account to be able to check this). After making sure they are in the storage account, you can then run and debug theAutomatedTest
test in TI. To be able to run it, you need to set theAZURE_STORAGE_CONNECTION_STRING
for thecdctiautomatedstg
account. I can give that to you. Otherwise, you can also run theAutomated Staging Test - Run integration tests
workflow, but you won't be able to debug there