-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e/1452/map local and loinc codes #1515
Conversation
@@ -0,0 +1,7 @@ | |||
MSH|^~\&|SISGDSP|SISGDSP|SISHIERECEIVER^11903029^L,M,N|^automated-staging-test-receiver-id^L,M,N|20240226034304||ORU^R01^ORU_R01|006|N|2.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running the assertions on these files but for some reason the Hapi library is not able to parse them. It triggers an error when trying to parse the 2.5.1 version number: ca.uhn.hl7v2.HL7Exception: The HL7 version 2.5.1\nPID is not recognized
. I also noticed the files Gilmore added are not getting parsed either. Could you try adding a |
after 2.5.1
? That may fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the 4 files. Could you try them again? *Also, what's your process for running the assertions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run the Automated Staging Test - Submit Messages
github workflow on the branch to send the new files to RS staging. You can then check they are delivered to the RS blob storage account cdctiautomatedstg
(you need to log in to your -SU account to be able to check this). After making sure they are in the storage account, you can then run and debug the AutomatedTest
test in TI. To be able to run it, you need to set the AZURE_STORAGE_CONNECTION_STRING
for the cdctiautomatedstg
account. I can give that to you. Otherwise, you can also run the Automated Staging Test - Run integration tests
workflow, but you won't be able to debug there
…arsing with the Hapi library
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Add RS E2E tests for mapping local to LOINC/PLT codes
This PR adds new ReportStream E2E tests to ensure that mapping of local to LOINC and PLT codes works as expected.
Issue
#1452
Checklist
Note: You may remove items that are not applicable