Implementation to send the FHIR result to RS Waters endpoint #859
Conversation
…d send method for results
| @@ -0,0 +1,78 @@ | |||
| package gov.hhs.cdc.trustedintermediary.external.reportstream; | |||
There was a problem hiding this comment.
I like that we're using a helper class instead of inheritance.
There was a problem hiding this comment.
Cool, we're also using a helper class as well in our other PR for the Order/Result Conversion use cases.
| ReportStreamSenderHelper.getInstance().sendToReportStream(_ as String, _ as String, _ as String) | ||
|
|
||
| then: | ||
| noExceptionThrown() |
There was a problem hiding this comment.
No need for noExceptionThrown() if you have another assertion. Spock doesn't allow empty then: statements, so noExceptionThrown() is only needed when it would be the only assertion. No exceptions are allowed to be thrown even if we don't explicitly include the noExceptionThrown() assertion.
|
|
||
| then: | ||
| noExceptionThrown() | ||
| 1 * ReportStreamSenderHelper.getInstance().metadata.put(_, EtorMetadataStep.SENT_TO_REPORT_STREAM) |
There was a problem hiding this comment.
Shouldn't we assert more than just that we registered an internal metadata step? It looks like our old test didn't assert anything other than no exception was thrown, but yeah, I think we should at least assert that our RS client was called once.
E.g. something like
1 * mockRsClient.requestWatersEndpoint(_ as String, _ as String).
|
Implementation to send the FHIR result to RS Waters endpoint
ReportStreamResultSender.sendto call RS water APIReportStreamOrderSenderandReportStreamResultSenderinto helper class:ReportStreamSenderHelperIssue
#616
Checklist