generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Fields From FHIR Bundle #982
Merged
+1,161
−160
Merged
Changes from 1 commit
Commits
Show all changes
100 commits
Select commit
Hold shift + click to select a range
ec8c33e
added method skeleton to extract fields
jorg3lopez e3faffd
all tests pass
jorg3lopez d07b9d4
fields added to ResultMock, tests are passing
jorg3lopez 81baff3
Added fields to OrderMock, tests are passing
jorg3lopez 369ee9f
Merge branch 'main' into story/621/extract-ids
jorg3lopez 927c0bf
unit tests skeleton, ready for TDD
jorg3lopez 5354a15
getSendingApplicationId
jorg3lopez a4a60cc
getSendingApplicationId final
jorg3lopez 869d7ef
getSendingFacilityId
jorg3lopez 79d4ad8
Add Place Order Number to HapiResult
saquino0827 757374e
Merge branch 'story/621/extract-ids' of https://github.com/CDCgov/tru…
saquino0827 d37b363
Add SendingApplicationId to HapiResult
saquino0827 6547849
Merge branch 'main' into story/621/extract-ids
jorg3lopez aae14a4
getReceivingApplicationId
jorg3lopez 3b1d269
getReceivingApplicationId -> getReceivingApplicationDetails
jorg3lopez 2519d4d
getSendingApplicationid -> getSendingApplicationDetails
jorg3lopez f848e30
receivingApplicationDetails full extraction
jorg3lopez 46b2ddb
Added OrderNumber extract
jherrflexion 7d1aee8
Added missing import
jherrflexion f6fc76c
messageDetails pojo
jorg3lopez 9b8e7c8
javadocs for pojo
jorg3lopez 7b15ad1
getStringFromFhirPath()
jorg3lopez 8f2fc51
unit test: getStringFromFhirPath returns correct string value
jorg3lopez 3ce9f67
unit test: getStringFromFhirPath() returns empty string
jorg3lopez 71f29d8
unit test: getStringFromFhirPath() handles complex paths correctly
jorg3lopez 6f70726
use .evaluateFirst() instead of .evaluate()
jorg3lopez 3e7de2a
MessageDetails -> MessageHdDataType
jorg3lopez ee86133
external link to javadocs
jorg3lopez b30ba33
refactor javdocs
jorg3lopez 27f8870
Merge branch 'main' into story/621/extract-ids
jorg3lopez f2af5b3
javadocs for getStringFromFhirPath
jorg3lopez 391f3e7
Base.class instead of StringType.class
jorg3lopez 7665230
Extract IDs Metadata Extract Refactoring (#999)
jorg3lopez 73126b8
added setup() to HapiOrderTest
jorg3lopez b70223c
Update Order and Result data extraction
saquino0827 39f8f8a
Update HapiOrder to use HapiMessageHelper
saquino0827 3d7bc3e
Fix usage of HapiMessageHelper class in HapiOrder/HapiResult
saquino0827 caa7310
Change Order/Result mocks with their respective correct field names
saquino0827 9cdd994
Update HapiOrderTest and HapiMessageHelper handling for getSendingApp…
saquino0827 721c7a3
created skeletons for methods that extract values
jorg3lopez 519ab20
merged conflicts
jorg3lopez 815e566
add extraction logic to methods
jorg3lopez 080c19b
fixed some failing tests and refactored
jorg3lopez 68f0186
fixed HapiOrderConverterTests that were failing
jorg3lopez 3c36fe3
fixed failing tests from OrderControllerTest
jorg3lopez 363318d
All tests work except for the ones using .resolve()
jorg3lopez 44c4f4c
extractSendingFacilityDetails() uses fhir bundle object, all current …
jorg3lopez 727adac
all tests pass
jorg3lopez 23deba3
Tweaked HapiResult to match HapiOrder changes
luis-pabon-tf c6c9fea
Update HapiResult and HapiResult
saquino0827 f9ca6c4
Merge branch 'story/621/extract-ids' of https://github.com/CDCgov/tru…
saquino0827 cc8866b
Refactor work for HapiMessageHelper, Order and Result
saquino0827 76f8a89
Update unit tests for HapiOrder
saquino0827 f593f19
fixed ResultMock
jorg3lopez f1fd06c
no toString() in pojo
jorg3lopez 9fe816a
fixed MessageHDDataTypeTest
jorg3lopez e7da577
fixed ResultControllerTest failing tests
jorg3lopez d91f590
fixed HapiReslutConverterTest failing tests
jorg3lopez 0266d2b
pojo -> record
jorg3lopez b1919c4
edit javadoc for pojo
jorg3lopez d969453
Update HapiResult unit tests
saquino0827 84ce7e7
Merge branch 'story/621/extract-ids' of https://github.com/CDCgov/tru…
saquino0827 3119aa1
Create Message.java
luis-pabon-tf 27f8f78
Make Order and Result extend Message
luis-pabon-tf 0832e42
Fixed missing rename
luis-pabon-tf a4992b2
unit test: receivingFacilityDetails happy path
jorg3lopez 9c59827
unit test: getReceivingFacilityDetails unhappy path
jorg3lopez 6f48e59
skeleton for HapiMessageHelperTest
jorg3lopez ea8134f
remove spaces from text blocks
jorg3lopez 7c65c82
Extract Fhir paths to new FhirPath enum in a new plugin directory
saquino0827 30932c4
Merge branch 'story/621/extract-ids' of https://github.com/CDCgov/tru…
saquino0827 71b93a0
Fix HapiFhir injection for HapiMessageHelper
saquino0827 8390285
deleted redundant test: HapiMessageHelperTest
jorg3lopez 46595fa
clear white spaces from long fhir paths
jorg3lopez b75f4dd
clear white spaces from short fhir paths
jorg3lopez ed83d18
refactor: HapiOrderTest
jorg3lopez c0ffbf6
add helper methods to HapiResultTest
jorg3lopez 8018bc6
refactor: HapiResultTest-unhappy path cases
jorg3lopez f6fb1b5
refactor: HapiResultTest-getSendingApplicationDetails
jorg3lopez 50fd379
refactor: HapiResultTest-getSendingFacilityDetails
jorg3lopez e12b1bf
refactor: HapiResultTest-getReceivingApplicationDetails
jorg3lopez c3d4be7
refactor: HapiResultTest-getReceivingFacilityDetails
jorg3lopez 29e90e7
refactor: Order.java and Result.java :: javadocs
jorg3lopez 229914a
javadocs: Message.java
jorg3lopez 0dc7e1b
javadocs: HapiMessageHelper.java
jorg3lopez b6cb0c8
refactor: HapiOrder
jorg3lopez 112b9a0
refactor: HapiResult
jorg3lopez b26b96e
javadocs: FhirPath.java
jorg3lopez c77cc29
unit tests for extractMessageHdDataType
jorg3lopez 48bc904
Merge branch 'main' into story/621/extract-ids
jorg3lopez ab61789
fixed HapiResultTest
jorg3lopez 709f014
renamed helper methods to include result in HapiResultTest
jorg3lopez 7a39a9f
Message interface now extends FhirResource
luis-pabon-tf 38735e0
Moved getFhirResourceId to FhirResource interface
luis-pabon-tf 0134326
remove wildcard import
jorg3lopez 06a2ac5
aded: as reference to test case
jorg3lopez 1a9835d
Add common parent for hapiOrder and hapiResult
luis-pabon-tf 6e8f9c5
Extending Demographics interface with FhirResource
luis-pabon-tf cd0b882
HapiDemographics is another implementation of the same FhirResource l…
luis-pabon-tf 5e6f039
Move getPatientId up the chain
luis-pabon-tf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,6 @@ | |
*/ | ||
public interface FhirResource<T> { | ||
T getUnderlyingResource(); | ||
|
||
String getFhirResourceId(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luis-pabon-tf Any idea why it shows that this method is not covered by the tests in HapiOrderTest and HapiResultTest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this before seeing this was commented. Let's keep track of test coverage for this and make another PR to fix it if necessary.