Extract Fields From FHIR Bundle

[jorg3lopez]

Extract Fields From FHIR Bundle

This PR adds the logic to extract the following fields from the FHIR bundle:

• placer order number
• sending application id
• sending facility id
• receiving application id
• receiving facility id

These fields are extracted from orders and results.

Issue

#621

Checklist

• I have added tests to cover my changes
• I have added logging where useful (with appropriate log level)
• I have added JavaDocs where required
• I have updated the documentation accordingly

[halprin]

I talked with the HL7 SMEs. They stated that the MSH fields' most important sub-fields are the first two, and the ORC field's most important sub-fields are the first three. This basically means that we shouldn't just return a single ID for each of these new methods we're adding. Honestly, we might as well include all of the sub-fields.

We should either add additional methods for each sub-field, have the existing method return all the important sub-fields with some delimiter (e.g. 1234^other_stuff^moof using ^ as the delimiter), have the existing method return a POJO (Plain Old Java Object) that has the sub-fields, or some other solution that I'm not thinking of.

[jorg3lopez]

I talked with the HL7 SMEs. They stated that the MSH fields' most important sub-fields are the first two, and the ORC field's most important sub-fields are the first three. This basically means that we shouldn't just return a single ID for each of these new methods we're adding. Honestly, we might as well include all of the sub-fields.

We should either add additional methods for each sub-field, have the existing method return all the important sub-fields with some delimiter (e.g. 1234^other_stuff^moof using ^ as the delimiter), have the existing method return a POJO (Plain Old Java Object) that has the sub-fields, or some other solution that I'm not thinking of.

Yes. I noticed that we would have to get more than a sub-field. I'm taking the namespace-id, universal-id, and universal-type-id for the most part. I already have a method that concatenates and joins the fields with a caret. I still haven't looked into isolating each id for later use. Right now, I'm only spitting out something like: Epic^1.2.840.114350.1.13.145.2.7.2.695071^ISO

[basiliskus]

Great job on this PR! I just left a few minor comments

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
99.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[basiliskus]

Great work!

[jorg3lopez]

@luis-pabon-tf Any idea why it shows that this method is not covered by the tests in HapiOrderTest and HapiResultTest?

[saquino0827]

I merged this before seeing this was commented. Let's keep track of test coverage for this and make another PR to fix it if necessary.