Surrogate Assisted Causal Testing #250
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 29 | 1 | 1.05s | ||
| ✅ PYTHON | pylint | 29 | 0 | 4.47s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
|
Thanks for this @rsomers1998 - I'm just going to close this PR as it's causing the unit tests to fail. We'll still have access to your branch once we come to it |
…for hidden variables
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 95.32% 95.69% +0.37%
==========================================
Files 20 22 +2
Lines 1411 1557 +146
==========================================
+ Hits 1345 1490 +145
- Misses 66 67 +1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
I've focused on the files that will become part of the framework, rather than the example specific files. Overall looks really good! Your use of typing, class layouts etc are all great.
Only subject we have to discuss before merging will be the dreaded unit tests
| solution_dict[adj] = solution[idx + 1] | ||
| solutions.append((solution_dict, fitness, fitness_function.surrogate_model)) | ||
|
|
||
| return max( |
There was a problem hiding this comment.
What is the purpose of the itemgetter inside this max function? My understanding of itemgetter is that it defines a function which then you can use to get items from an object. But it doesn't appear to be 'getting' from anything
There was a problem hiding this comment.
Solutions is a tuple of (data, fitness, model). I use itemgetter here to tell the max function to use index 1 as the sorting key. Is there a better way of doing this?
…eassisted # Conflicts: # tests/surrogate_tests/test_causal_surrogate_assisted.py # tests/testing_tests/test_estimators.py
No description provided.