Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue: #12373
This PR addresses adding a bounds check on the
ScreenSpaceEventHandler
handleMouseMove
this issue was only reproducible in Firefox. Checking to make sure the client is inside the bounds of the canvas solves this issueWhen integration Cesium in existing application, if menus are overlayed on the canvas then in firefox the event is triggered even though its not in the canvas
Issue number and link
#12373
Testing plan
Using the given example in the Issue, after my change I tested in Firefox, and Chrome. Note: I did this on a Mac.
Automated tests were updated to have a valid
boundingClientRect
so that it passes the new check. Also added a new test to ensure the event is not fired when in the bounds of the canvasAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change