Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prospective-parachains): Implement FragmentChain #4337

Merged
merged 39 commits into from
Jan 6, 2025
Merged

feat(prospective-parachains): Implement FragmentChain #4337

merged 39 commits into from
Jan 6, 2025

Conversation

EclesioMeloJunior
Copy link
Member

Changes

  • Implements Fragment Chain a data structure used by prospective-parachains subsystems in order to keep the best backable chain of parachain blocks
  • The goal is to always choose the best candidate to back on-chain

Tests

Tests coverage from Polkadot-SDK

go test -timeout 10m github.com/ChainSafe/gossamer/dot/parachain/prospective-parachains/fragment-chain

Issues

haikoschol
haikoschol approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@haikoschol haikoschol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some types, nits & questions

dot/parachain/util/.DS_Store Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/errors.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/errors.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/types/async_backing.go Outdated Show resolved Hide resolved
dot/parachain/util/inclusion-emulator/inclusion_emulator.go Outdated Show resolved Hide resolved
axaysagathiya
axaysagathiya reviewed Dec 3, 2024
View reviewed changes
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
This was referenced Dec 3, 2024
Open
Open
jimjbrettj
jimjbrettj approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

axaysagathiya
axaysagathiya reviewed Dec 11, 2024
View reviewed changes
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment-chain/fragment_chain.go Outdated Show resolved Hide resolved
axaysagathiya
axaysagathiya reviewed Dec 12, 2024
View reviewed changes
dot/parachain/types/types.go Outdated Show resolved Hide resolved
dot/parachain/types/types.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/errors.go Outdated Show resolved Hide resolved
axaysagathiya
axaysagathiya reviewed Dec 13, 2024
View reviewed changes
dot/parachain/types/async_backing.go Outdated Show resolved Hide resolved
dot/parachain/types/async_backing.go Outdated Show resolved Hide resolved
dot/parachain/types/types.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/errors.go Outdated Show resolved Hide resolved
axaysagathiya
axaysagathiya approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@axaysagathiya axaysagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.
You can merge after addressing the comments.

dot/parachain/prospective-parachains/fragment_chain.go Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment_chain.go Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment_chain.go Show resolved Hide resolved
dot/parachain/types/types.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment_chain.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/fragment_chain.go Outdated Show resolved Hide resolved
@EclesioMeloJunior EclesioMeloJunior merged commit 3225678 into feat/parachain Jan 6, 2025
22 checks passed
@EclesioMeloJunior EclesioMeloJunior deleted the eclesio/fragment-chain-impl branch January 6, 2025 20:51
@EclesioMeloJunior EclesioMeloJunior restored the eclesio/fragment-chain-impl branch January 6, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haikoschol haikoschol haikoschol approved these changes

@DanielDDHM DanielDDHM DanielDDHM approved these changes

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@axaysagathiya axaysagathiya axaysagathiya approved these changes

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@P1sar P1sar Awaiting requested review from P1sar P1sar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EclesioMeloJunior @haikoschol @axaysagathiya @jimjbrettj @DanielDDHM