Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Pages #350

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Active Pages #350

merged 5 commits into from
Jun 24, 2024

Conversation

NeerajaGurram
Copy link
Contributor

PR Description 📜

changes made such that the current active page can be known seeing the navbar( included border bottom).
before:

image

after:

Chrome.Gaming._.Home.-.Google.Chrome.2024-06-23.11-14-26_Trim.mp4

Fixes #336

let me know if there can be made any changes to improve. i would like to work on them.
Thankyou.


Mark the task you have completed ✅

  • [x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [ x] I have performed a self-review of my own code or work.
  • [ x] I have commented my code, particularly in hard-to-understand areas.
  • [ x] My changes generates no new warnings.
  • [ x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ x] I have added screenshot for review.

## Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
community-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 6:01am

@NeerajaGurram NeerajaGurram changed the title Activepages Active Pages Jun 23, 2024
@NeerajaGurram NeerajaGurram mentioned this pull request Jun 23, 2024
Copy link
Collaborator

@Manaregr8 Manaregr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Work ! nicely done

@Manaregr8 Manaregr8 merged commit ea23a08 into ChromeGaming:main Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: effect on active navbar link indicating the page in which the user is in
2 participants