-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update vue 2 reactivity #1773
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 99.10% 98.94% -0.17%
==========================================
Files 90 90
Lines 5917 5946 +29
Branches 494 499 +5
==========================================
+ Hits 5864 5883 +19
- Misses 50 60 +10
Partials 3 3 β View full report in Codecov by Sentry. |
I don't know how to have 100% of code coverage with Vue 2 conditions, maybe it's possible to combine multiple reports with |
Some tests are failing with |
@Graphmaxer Thanks for the PR. I try to look into it and think about it. |
I updated the test |
I found a proper way without |
Thanks for your PR, it works well for me, reactivity is working again! Tested on 2.7.16. |
Any update on the review @CodeDredd ? |
@CodeDredd if you found a minute to review and release this, I'd really appreciate it! Thanks for your time |
π Linked issue
#1772
β Type of change
π Description
When updating an object in Vue 2, we cannot use directly
Object.assign
with 2 params anddelete
is not reactive.cf. https://v2.vuejs.org/v2/guide/reactivity.html#For-Objects
π Checklist