Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vue 2 reactivity #1773

Merged
merged 6 commits into from
May 1, 2024
+148 −5
Merged

fix: update vue 2 reactivity #1773

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b289c7b
fix: use vue2 set and delete to update store state with reactivity
Graphmaxer Feb 1, 2024
94dd3d4
chore: fix lint
Graphmaxer Feb 2, 2024
8aee9b7
feat: move vue-demi to dev deps and update perf test
Graphmaxer Feb 7, 2024
c78ee11
fix: update vue 2 reactivity
Graphmaxer Feb 9, 2024
eea490e
feat: add reactivity tests
Graphmaxer Feb 9, 2024
4e7be48
chore: add v8 ignore to vue 2 specific code
Graphmaxer Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: add v8 ignore to vue 2 specific code
@Graphmaxer
Graphmaxer committed Feb 9, 2024
commit 4e7be488cc01717cdb5dae8a9b6a5f8cbc0abf1b
2 changes: 2 additions & 0 deletions packages/pinia-orm/src/composables/useStoreActions.ts
View file
Original file line number Diff line number Diff line change
@@ -30,6 +30,7 @@ export function useStoreActions (query?: Query) {
} else {
ids.forEach(id => delete this.data[id])
// Trigger Vue 2 reactivity
/* v8 ignore next 3 */
if (this.data.__ob__) {
this.data.__ob__.dep.notify()
}
@@ -44,6 +45,7 @@ export function useStoreActions (query?: Query) {
} else {
ids.forEach(id => delete this.data[id])
// Trigger Vue 2 reactivity
/* v8 ignore next 3 */
if (this.data.__ob__) {
this.data.__ob__.dep.notify()
}