DX: replace nbstripout by nb-clean #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenvitor
changed the title
for more information, see https://pre-commit.ci
redeboer
requested changes
Aug 22, 2024
.pre-commit-config.yaml
Outdated
| - --remove-empty-cells | ||
| - --preserve-cell-metadata | ||
| - tags | ||
| - slideshow |
There was a problem hiding this comment.
I would also remove slideshow. Only keep tags (which are used by myst-nb)
| cell.metadata.slideshow | ||
| - --remove-empty-cells | ||
| - --preserve-cell-metadata | ||
| - tags |
There was a problem hiding this comment.
Also keep jupyter and mystnb (see 4420106)
|
Change strategy: seems like it is ok to remove empty cells in nbstripout too, so I will try in another PR #92 |
|
Change strategy and replaced by new PR #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/srstevenson/nb-clean