Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: replace nbstripout by nb-clean #91

Closed
wants to merge 3 commits into from
Closed

DX: replace nbstripout by nb-clean #91

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bceeec
replace nbstripout by nbclean using the example
shenvitor Aug 22, 2024
4420106
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 22, 2024
fc60498
update
shenvitor Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,16 @@ repos:
.*\.py
)$

- repo: https://github.com/kynan/nbstripout
rev: 0.7.1
- repo: https://github.com/srstevenson/nb-clean
rev: 3.3.0
hooks:
- id: nbstripout
- id: nb-clean
args:
- --extra-keys
- |
cell.attachments
cell.metadata.editable
cell.metadata.id
cell.metadata.slideshow
- --remove-empty-cells
- --preserve-cell-metadata
- tags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also keep jupyter and mystnb (see 4420106)

- slideshow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also remove slideshow. Only keep tags (which are used by myst-nb)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- --

- repo: https://github.com/pre-commit/mirrors-prettier
rev: v4.0.0-alpha.8
Expand Down
Loading