Design System: Design tokens #2203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoachimTillessen
changed the title
LCOV of commit
|
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
2 times, most recently
from
b197516
to
a34c671
Compare
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
from
051e594
to
3019014
Compare
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
from
3019014
to
6de0243
Compare
LCOV of commit
|
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
from
6de0243
to
efea878
Compare
LCOV of commit
|
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
from
efea878
to
c718561
Compare
LCOV of commit
|
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
2 times, most recently
from
32bb9b4
to
80403e0
Compare
LCOV of commit
|
LCOV of commit
|
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
2 times, most recently
from
18b2107
to
dda6925
Compare
LCOV of commit
|
LCOV of commit
|
JoachimTillessen
force-pushed
the
upadate-bootstrap-styleguide
branch
from
dda6925
to
2bbca4d
Compare
Assigning to `el_composition.data` would cause the sample to be considered as `isEdited`.
Before this change, we would `this.state.sortColumn = ...` during render in order to get the latest value from UserStore. Now we properly listen (and unlisten) for store changes and update the state using `this.setState`. With this change we also set the initial UIStore state when the component mounts and not only when the store state changes.
The ManagingActions component handles syncing genericEls with UserStore itself. No need to pass that information in as prop.
We used to copy the state to determine whether the selection had changed or not. However, we can simply calculate that information from the UIStore state without the local state.
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
from
09156be
to
6a9b734
Compare
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
The first <Popover.Header> is not the first DOM node in the <Popover>. React bootstrap prepends another element for the arrow, so :first-child does not work here. I attempted to use `.popover > *:nth-child(n + 2 of .popover-header)` but I suppose our css preprocessor does not support the relatively new nth-of selector, because the selector is mangled in the compiled output. https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#the_of_selector_syntax
This patch introduces the TabLayoutEditor component with a drag-and-drop interface for reordering and hiding/showing tabs. The component accepts an ItemComponent via the `getItemComponent` prop for rendering individual items. With this patch we no longer need to manage the synthetic 'hidden' Tab when no tabs are currently hidden. This is now the editor component's responsibility and using code does not have to manage that. This also removes the `DragDropItemTypes.LAYOUT` constant in favor of a unique scope for each instance of the editor, because drag-and-drop is only supposed to work within a specific visible/hidden list combination and not globally across editors. State changes are now propagated via the `onLayoutChange` callback and not by reaching into the state of the component.
maiwald
force-pushed
the
upadate-bootstrap-styleguide
branch
from
e2e6aa9
to
e686f49
Compare
LCOV of commit
|
|
Closing, because all progress has moved to #2211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.